Repository navigation
fix: keep local terminal rows inside the padded pane - #62
Merged
Merged
Conversation
|
AI review | Looks safe to merge Moves padding from the xterm mount element to its wrapper to prevent terminal row overflow, and adds a layout test. The change is safe and meets repo standards. Reviewed 5b42811. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local Terminal puts padding on xterm's mount element, whose border-box height FitAddon uses as the available space. This counts the padding as terminal space and can place the last row outside the pane.
Move the existing padding to the wrapper so the mount reports the actual content area. Preserve the same visual inset and terminal overlay. Synchronize the SDK lock entry with the existing package.json requirement so clean CI installs succeed.
Related to #55; the report's screenshots show Local Terminal.
Validation: real xterm/FitAddon in headless Chromium across six pane heights reproduces overflow before the fix and no overflow afterward. Six component/FitAddon regressions fail on the original layout and pass with the change. Clean npm ci, all 644 tests, typecheck, build, manifest validation and formatting passed. Native macOS/Electron acceptance remains unverified.